search

inviqa / dock-cli

Dock CLI
MIT License
39 stars 14 forks source link

Use right configuration file on systemd systems #139

Open mareg opened 7 years ago

mareg commented 7 years ago

As described in the documentation Fedora and Ubuntu (as of version 15.04) both use systemd now.

I still believe dock-cli should not use explicit IP but depend on what docker gets assigned, albeit this change will allow dock-cli to run on linux systems for now.

sroze commented 7 years ago

Looks good 👍

But needs to be tested on Ubuntu first!

mareg commented 7 years ago

@mlopes tested on Ubuntu and reported issues, I'll re-test later in the vm to see if I can mitigate that.

Basically tee fails to create a file - possibly because folder does not exists?

andytson-inviqa commented 7 years ago

what happens if used on a Linux distro that doesn't use systemd? perhaps should check if systemd is in use and fallback to the removed code?

sroze commented 7 years ago

@mareg any update? Still using dock-cli?

mareg commented 6 years ago

@sroze I've stopped using dock-cli and switched to use Træfik + make files :wink: