inviqa / harness-base-php

Base PHP harness for workspace https://github.com/my127/workspace
Other
4 stars 5 forks source link

Remove duplicate php-fpm container #763

Closed kierenevans closed 1 year ago

kierenevans commented 1 year ago

Fixes #761

services.php-fpm.enabled is true for helm chart purposes since #609, so will be included as part of the main application.yml.twig loop over enabled services.

A few alternatives:

  1. Set enabled to false in services for docker and true in helm for pipeline.base.services (potential breaking change?)
  2. Add an if statement in the application.yml.twig to skip over php-fpm.
andytson-inviqa commented 1 year ago

or 3. set a variable in webapp.yml which is checked to conditionally render php/nginx if webapp service is enabled and the variable is set

andytson-inviqa commented 1 year ago

I'll try a PR with that to compare

andytson-inviqa commented 1 year ago

went with #765 instead