search

invisible-college / statebus

All aboard the STATEBUS!!!
117 stars 5 forks source link

Fix textareas resetting themselves when contents are deleted #48

Closed Slickytail closed 2 years ago

toomim commented 2 years ago

This looks good. I'll go ahead and merge it. But can you explain how the bug presents— what does it mean for a textarea to "reset itself"?

Slickytail commented 2 years ago

If you create a textarea as follows:

TEXTAREA
    value: some_state.text

and then, while typing in the textarea, delete all text contents, the contents of the textarea will be reset back to the initial value.

This is because when all the text content is deleted, the value property of the corresponding Dom element is falsey.

On Tue, Jul 12, 2022, 23:43 Michael Toomim @.***> wrote:

This looks good. I'll go ahead and merge it. But can you explain how the bug presents— what does it mean for a textarea to "reset itself"?

— Reply to this email directly, view it on GitHub https://github.com/invisible-college/statebus/pull/48#issuecomment-1182527948, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDXG7PVDCC7KM7O6HO3743VTXRJTANCNFSM53HWHRNA . You are receiving this because you authored the thread.Message ID: @.***>

toomim commented 2 years ago

Oh, that makes total sense. Thank you. I'll be careful about those "" falsey issues in the future.