search

invisibleroads / socketIO-client

A socket.io client library for Python
http://pypi.python.org/pypi/socketIO-client
MIT License
447 stars 205 forks source link

Fix wait() seconds argument with None as value #125

Closed khairihafsham closed 7 years ago

khairihafsham commented 8 years ago

At least for python > 3.4, min() does not accept None as argument. If SocketIO.wait() is called without argument, the seconds param is set to None by default, this causes min() to raise Exception.

Since this only effect how timeout is set, I've made it into a separate code for easier testing.

khairihafsham commented 8 years ago

For some unknown reason, the CI doesn't run the test, or timeout at nosetests stage. I've tried closing and opening this PR 3 times to re-trigger the CI. But I think it doesn't work.

Can anyone please help? The tests passes when I run them in my machine.

invisibleroads commented 7 years ago

Thanks Khairi!