search

invisnik / laravel-steam-auth

Laravel Steam Auth
MIT License
172 stars 69 forks source link

Move config/steam-auth.php info in config/services.php #16

Closed abenevaut closed 8 years ago

abenevaut commented 8 years ago

Could you move config/steam-auth.php info in config/services.php like OAuth package https://github.com/laravel/socialite ?

Gummibeer commented 8 years ago

@42antoine I'm totaly on your side - the only problem would be that it is a breaking change and it's not possible, with laravel ways, to append to a config - so the devs have to insert it by there own. But yes, it would be the better place!

@invisnik a much better solution would be to use app('config')->get(...)

Gummibeer commented 8 years ago

@invisnik Why won't fix?