search

invisnik / laravel-steam-auth

Laravel Steam Auth
MIT License
172 stars 69 forks source link

https is not functioning #22

Closed Ministorm3 closed 8 years ago

Ministorm3 commented 8 years ago

If the site is https, then the openid.realm must reflect that. Otherwise the login fails. There is the start of code to correct this, but it is not correct.

Add to config file: 'https' => true,

However, that still did not fix it.

In SteamAuth.php line ~131 change the following... 'openid.realm' => \Config::get('steam-auth.https') ? 'https' : 'http' . '://' . $this->request->server('HTTP_HOST'),

...to this... 'openid.realm' => \Config::get('steam-auth.https') ? 'https' . '://' . $this->request->server('HTTP_HOST') : 'http' . '://' . $this->request->server('HTTP_HOST'),

Ministorm3 commented 8 years ago

Or, do a better job than I did at fixing it. I think my fix doesn't actually work.

Ministorm3 commented 8 years ago

One more comment. Yes it does fix it.

Gummibeer commented 8 years ago

Meaned is this line: https://github.com/invisnik/laravel-steam-auth/blob/master/src/SteamAuth.php#L131 and fixed it look's like this: https://github.com/invisnik/laravel-steam-auth/pull/23/files

@ajanes3: don't duplicate too much code ;)

Gummibeer commented 8 years ago

@invisnik also solved after PR #23 is merged!?

invisnik commented 8 years ago

@Gummibeer i guess so :)