search

invisnik / laravel-steam-auth

Laravel Steam Auth
MIT License
172 stars 69 forks source link

Drop PHP5 support #89

Closed Gummibeer closed 5 years ago

Gummibeer commented 6 years ago

PHP 5 ist out of support for more than one year and looses security support end of this year. http://php.net/supported-versions.php PHP 7 adds a lot of new features, is faster and we can't stay with PHP 5 forever. 😉

I would send a PR that brings this library to PHP 7.

kanalumaddela commented 6 years ago

What would you change that "brings this library to PHP 7" ???

Change

$steamID = isset($data['steamid']) ? $data['steamid'] : null;

to

$steamID = $data['steamid'] ?? null;

😂

Bumping up the minimum PHP version makes no sense if all you're trying to do is get people on PHP7. It'd be helpful if you actually provided examples or at least some code utilizing PHP7 that warrants being good enough to make the new minimum.

Gummibeer commented 6 years ago

http://php.net/manual/de/migration70.new-features.php The most common and requested feature is the scalar type hinting.

kanalumaddela commented 6 years ago

Listing PHP7 features doesn't mean anything. How does type hinting benefit this lib? All it does is improve code quality, it doesn't increase its performance whatsoever. Same applies to return type declarations.

Gummibeer commented 6 years ago

And code quality, type security and for sure performance aren't reasons to go with the time!? 😉 Everyone that stays with PHP5 can still use older versions. But everyone else benefits. Also by up2date dependencies which isn't possible atm.