search

invisnik / laravel-steam-auth

Laravel Steam Auth
MIT License
172 stars 69 forks source link

phpunit is useless and outdated #91

Closed Gummibeer closed 6 years ago

Gummibeer commented 6 years ago

There are no phpunit tests atm except of one true===true check. I would drop it for the moment and add some tests later with the latest phpunit version.

Gummibeer commented 6 years ago

@invisnik this isn't done yet - https://travis-ci.org/invisnik/laravel-steam-auth/builds/366064979?utm_source=github_status&utm_medium=notification

PhpUnit 3 is too old for PHP7.2 - so we should find a decision where to go!?

In my opinion we should drop all PHP5 versions ( #89 ), just go with PHP7 and update all dependencies accordingly. This also means dropping some Laravel5 versions (cause they are compatible with PHP5).

And the SteamAuth class isn't tested in any way.