Closed duskybomb closed 6 years ago
Here is the issue with this PR:
\EmbeddedFiles
is contained in \Names
\Names
doesn't exist. If \Names
doesn't exist, \EmbeddedFiles
also can't exist.\Names
.\Names
exists, check for \EmbeddedFiles
.By doing this you can take advantage of the fact that Python checks AND conditions from left to right.
You mean I should use nested if?
Using an and
would be clearest. But it's fine. If it fixes your issue, let's merge it. I didn't realize this is only a very minor check before reading the XML.
I also don't like too many not
s. This is generally a sign of bad layout.
We can merge this. It was my initial commit to branch
issue/16