Initial test - Githubissues

invoice-x / factur-x-ng

Python lib for Factur-X, the e-invoicing standard for France and Germany

Other

34 stars 8 forks source link

Closed duskybomb closed 6 years ago

duskybomb commented 6 years ago

A PR to keep track of tests

[x] _xml_from_file(): checking for pdf with and without embedded metadata.
- [x] for pdf without pdf check whether metadata has been added or not
- [x] what should I do for pdf with embedded data? Right now just checking whether returns None or not
[x] write_pdf():
- [x] check for pdf in directory
- [x] check data has been embedded or not
[x] write_xml(): should I parse it and compare?

duskybomb commented 6 years ago

I have been looking for how to compare two xml trees. I have found xmldiff. Recommended by stackoverflow and some blog

Should I use it @m3nu?

m3nu commented 6 years ago

xmldiff may be overkill since we are not interested in detailed differences, but in any difference. The latter is surely easier to implement.

duskybomb commented 6 years ago

Now this PR is ready for a review!

m3nu commented 6 years ago

Still needs lots of work as well.

m3nu commented 6 years ago

I'll merge this as starting point for tests, but I'm not too happy with it.