search

invoice-x / factur-x-ng

Python lib for Factur-X, the e-invoicing standard for France and Germany
Other
34 stars 8 forks source link

Implement validation #5

Closed m3nu closed 6 years ago

m3nu commented 6 years ago

There is an empty function is_valid() in facturx.py. This function should

  1. validate the XML file
  2. validate all fields with the _required attribute have a value
  3. other checks we can do.
duskybomb commented 6 years ago

To implement point no 2, we need to fix the base templates first as mentioned in #27.

duskybomb commented 6 years ago

I have implemented two checks right now:

I will create a PR after you merge #28 since is_valid() uses a few functions which are implemented in #28 in order to comply to DRY principle 😉

If you want to check the function you can visit here

m3nu commented 6 years ago

Sounds smart. Will try to merge everything today.

For the next 2 weeks I'm on Europe time, rather than Asia time. So all shifted a few hours.

duskybomb commented 6 years ago

I have implemented validation in branch issue/5

m3nu commented 6 years ago

Merged. Closing.