Currency field for converting currencies in recurring expense is not connected to any database table and created expense has an empty currency field there

[dleidert]

Setup

• Version: v5.7.6
• Environment: Docker

Checklist

• Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo? Yes

• Have you searched existing issues? Yes

• Have you reported this to Slack/forum before posting? No

• Have you inspected the logs in storage/logs/laravel.log for any errors? Yes

Describe the bug

When one creates a recurring expense and enables "Convert currency", then the currency field is not connected to a database table. If one deletes the content (defaults to "US Dollar") or starts typing, then no list pops up. Also, the created expense has an empty currency field in the "Convert currency" section.

Steps To Reproduce

Create a recurring expense. Enable "Convert currency". Delete the value. The field is empty. Add back "US Dollar" and complete the data. Wait for invoiceninja creating an expense. Check the currency field in the "Convert currency" section. It is empty.

Expected Behavior

a) The currency field should open a pop-up list with available currencies. b) The created expense should have the selected currency set in the "Convert currency" section.

Additional context

n/a

Screenshots

n/a (please let me know if you need any)

Logs

Nothing relevant in the log.

[turbo124]

Screencast from 03-09-23 10:53:34.webm

I'm not following this, are you saying the convert currency dropdown is not populating with currencies at all?

[dleidert]

Yes. That is correct. I can reproduce that at https://demo.invoiceninja.com/. The second part of the bug is, that the expense created from a recurring expense then has an empty currency field (in "Convert currency" - I just fixed a dozen created expenses). I'm not using the react interface.

[turbo124]

@dleidert

Thanks for reporting,I think i see the issue with this. I've checked in a fix for this here:

invoiceninja/invoiceninja#8773

[dleidert]

@turbo124 Thanks for your work. I just updated to v5.7.7, but in the "recurring expense" dialog, there are still no suggestion when I empty the currency field and start typing, thus this still seems to be a "free text field" and not connected to the currency list. Also, the field resets itself if I put in a value that should be valid. I'll attach a video.

Bildschirmaufzeichnung vom 2023-09-04, 13-02-59.webm

[hillelcoren]

Thanks for the video! Can you pleas try clicking the 'X' to clear the value and then search for a new value.

[dleidert]

@hillelcoren Same result. I just checked with version 5.7.8. There is no difference in removing the value using the "x" or by marking and deleting it.

[hillelcoren]

Do other currency fields in the app work, ie. when editing a client?

[dleidert]

@hillelcoren Yes. I'm using the app for some time now. I haven't spotted any other currency fields that don't work.

[dleidert]

JFTR: https://demo.invoiceninja.com/ shows the same (buggy) behavior. So, you should be able to reproduce that.

[hillelcoren]

Thanks for reporting this, it should be fixed in the next update of the Flutter app