invoiceninja / admin-portal

Invoice Ninja: Desktop/mobile admin portal built with Flutter
https://demo.invoiceninja.com
Other
1.56k stars 521 forks source link

German language/translation: Time tracked tasks/task-time-details show dot instead of comma as decimal seperator #650

Closed n1smithy closed 1 month ago

n1smithy commented 2 months ago

Setup

Interface

Checklist

Describe the bug

In settings one has checked "invoice task hours" and the system was setup to work with German localisation, especially that comma should be used as decimal seperator. After invoicing tasks the task-time-details show the amount of hours and minutes in decimal numbers. But instead of using a comma the decimal seperator still is a dot.

Steps To Reproduce

Set your system all over to German localisation-standards, check the check-box for "invoice task hours" and create a task. After that turn the task into an invoice. Just look at the PDF. :-D

Expected Behavior

Everywhere (!) should be the decimal seperator shown as a comma instead of a point, when option "Decimal Comma" was set to active.

Additional context

As you know German localisation uses (only for amounts of money (!)) commas for decimal seperation and dots as thousand-seperators. If it's not an amount of money one should use a non-breakable space to seperate every thousand. However, it seems that Invoice Ninja does not change it's look at some points. At least in invoices and other documents for customers it should be all the way correct.

Screenshots

Bildschirmfoto vom 2024-05-02 12-51-35

Look at the task-time-details in the screenshot above. The times are shown as: "0.4308 Hours" and "0.8397 Hours". In my German installation it would be like "0.8397 Std." but it should be "0,8397 Std.".