invoiceninja / dockerfiles

Docker files for Invoice Ninja
https://hub.docker.com/r/invoiceninja/invoiceninja
GNU General Public License v2.0
399 stars 263 forks source link

Missing appCipher setting? #471

Closed xeruf closed 1 year ago

xeruf commented 1 year ago

On the following pages it is mentioned that one can set a cipher along with the appkey: https://github.com/invoiceninja/invoiceninja/issues/1699, https://github.com/invoiceninja/invoiceninja/blob/master/.env.example, https://github.com/invoiceninja/dockerfiles/issues/54

But it seems to be missing from the helm chart options. Is this intentional? Am I supposed to set it as environment variable?

turbo124 commented 1 year ago

this would be for v4 only.

xeruf commented 1 year ago

So this option does not exist in v5 anymore? Then I guess it should be removed from https://github.com/invoiceninja/invoiceninja/blob/master/.env.example

turbo124 commented 1 year ago

That is the master branch which is v4,

for v5, you'll want to inspect the v5-stable branch.

xeruf commented 1 year ago

ah I see, it's just a bit confusing that v4 is still the default branch after v5 having long taken over

turbo124 commented 1 year ago

@xeruf

we are planning to switch branches shortly so that v5 is the main branch :)