Open Xenion1987 opened 1 year ago
@Xenion1987
I'll default to @lwj5 as he is the expert in this arena.
If it can't be included in the main repo, I am more than happy to create a separate branch for the traefik specific docker-compose.yml file and reference it in the README.
If it won't fit into this repo, maybe it could be maintained in the forum and mentioned in the Readme.
I think it's ok for the Traefik example to live in this repo.
Changes to be made
docker-compose.override.sample.yml
or a similar namedocker-compose.override.sample.yml
to docker-compose.override.yml
for a non-Traefik installbasic-auth
middlewareI've summarized the changes in the post above. Just create another PR with the changes and I'll take a look at it asap
@Xenion1987 @lwj5 just to clarify, the example could certainly exist in the repo, just in its own branch.
Hey there,
I hopefully can give an update about this issue over the weekend.
Hi @turbo124 and @lwj5
Related to #506 and #509, what can I (we) do to add the example files for using Traefik Proxy?
In my PR #506, I've made some changes to the docker-compose-files:
docker-compose.yml
and moved it to adocker-compose.override.yml
. The idea was to make possible customizations clearer for those who might not be too familiar with Docker. Additionally, this way you could make the templates from ./config/*/ easier to use with predefineddocker-compose.override.yml
files.My PR was reverted because of a possible broken
git pull
for those who already have their owndocker-compose.override.yml
in use. In itself I can understand the reason. The question now is how I could merge the traefik examples. The only way I can think of off the top of my head would be to maintain a completely separatedocker-compose.yml
file in the folder ./config/traefik in addition to the originaldocker-compose.yml
file.Another suggested change is in the
env
file. There I have split the variableAPP_URL
into three more finely granulated variables, which will be merged into the productive variableAPP_URL
at the end:LINK
What do you think about this adjustment?