invoiceninja / dockerfiles

Docker files for Invoice Ninja
https://hub.docker.com/r/invoiceninja/invoiceninja
GNU General Public License v2.0
387 stars 249 forks source link

Question: Neglecting config/hosts and extra_hosts ? #599

Open engemil opened 3 weeks ago

engemil commented 3 weeks ago

Trying to setup InvoiceNinja on a hosted server (not locally), and there are two things I'm considering neglecting/removing:

First, removing the extra_hosts from each service in the docker-compose file:

    extra_hosts:
      - "in5.localhost:192.168.0.124 " #host and ip

Second, removing the config/hosts-file.

I'm unsure if this will break any logic, as I read this in the documentation, quoting (README.md-file):

Note for people running the container locally on their PC

If you are running the container locally, then the container will need to resolve the host, to support this you will want to insert your LAN IP address and the host name in the hosts file located in config/hosts

For example, lets say your APP_URL is http://in5.test:8000 and your LAN IP is 192.168.0.124 the hosts file will have an entry looking like this:

192.168.0.124 in5.test

**Please note that for PDF generation using local host, your domain name MUST end in .test for your PDFs to generate correctly, this is a DNS resolver issue with chromium.

Kingwayer commented 3 weeks ago

From my experience, you can ignore both of extra_hosts and /config/hosts indeed, only focus on ports from docker-compose.yml and APP_URL from env is enough.

I have confused too from beginning.