PayPal Express with Braintree

mhosker commented 6 years ago

Hello,

I have recently been trying to use both PayPal express and Braintree card payments. However I think I have discovered a bug whereby when Braintree card payments are active the PayPal link completely fails to work, whereas the Braintree card payment link is ok. I can still access the PayPal link however it requires me to open it in a new tab and when clicking on it from the invoice pay menu it does nothing.

Any ideas as to why this may be?

Thanks, Mike

hillelcoren commented 6 years ago

I'm not sure... I'll try to reproduce the problem.

Is there a reason you aren't using Braintree's PayPal option? It's a better choice as it adds support for token billing enabling PayPal accounts to be re-used in the future.

hillelcoren commented 6 years ago

I'm seeing a problem but slightly different behavior.

The 'Pay Now' PayPal option is working but it show's Braintree's popup implementation rather than redirecting to PayPal. Using the link is taking me to PayPal to use PayPal Express.

Are you using other client portal settings, such as require a signature?

mhosker commented 6 years ago

Hello,

I liked the idea that the client could either enter there own card details or use thier existing PayPal account and pay that way without having to enter card details.

I am not using the require signature or any other special client portal settings.

No matter what browser I use the PayPal link will not work. However if I copy the URL for the PayPal button and load it in a new tab then it takes me to the PayPal login screen.

Thanks, Mike

hillelcoren commented 6 years ago

If you remove PayPal Express you should be able to enable the Braintree PayPal option with the same result.

hillelcoren commented 6 years ago

Are there any errors in the browser console when trying to pay with PayPal?

suculent commented 6 years ago

How do you remove braintree? There are also some private repos included.

Sending build context to Docker daemon 12.71 MB
Step 1/17 : FROM php:7.0-fpm
 ---> 99b3a8aba455
Step 2/17 : MAINTAINER Samuel Laulhau <sam@lalop.co>
 ---> Using cache
 ---> 629a03865252
Step 3/17 : ENV PHANTOMJS phantomjs-2.1.1-linux-x86_64
 ---> Using cache
 ---> 091e96f995dc
Step 4/17 : RUN apt-get update     && apt-get install -y --no-install-recommends         libmcrypt-dev zlib1g-dev git libgmp-dev         libfreetype6-dev libjpeg62-turbo-dev libpng12-dev         build-essential chrpath libssl-dev libxft-dev         libfreetype6 libfontconfig1 libfontconfig1-dev     && ln -s /usr/include/x86_64-linux-gnu/gmp.h /usr/local/include/     && docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/     && docker-php-ext-configure gmp     && docker-php-ext-install iconv mcrypt mbstring pdo pdo_mysql zip gd gmp opcache     && curl -o ${PHANTOMJS}.tar.bz2 -SL https://bitbucket.org/ariya/phantomjs/downloads/${PHANTOMJS}.tar.bz2     && tar xvjf ${PHANTOMJS}.tar.bz2     && rm ${PHANTOMJS}.tar.bz2     && mv ${PHANTOMJS} /usr/local/share     && ln -sf /usr/local/share/${PHANTOMJS}/bin/phantomjs /usr/local/bin     && rm -rf /var/lib/apt/lists/*
 ---> Using cache
 ---> 41f7d938aebf
Step 5/17 : RUN {       echo 'opcache.memory_consumption=128';      echo 'opcache.interned_strings_buffer=8';       echo 'opcache.max_accelerated_files=4000';      echo 'opcache.revalidate_freq=60';      echo 'opcache.fast_shutdown=1';         echo 'opcache.enable_cli=1'; } > /usr/local/etc/php/conf.d/opcache-recommended.ini
 ---> Using cache
 ---> d450535a7454
Step 6/17 : RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer
 ---> Using cache
 ---> e058a34aa556
Step 7/17 : ENV INVOICENINJA_VERSION 4.2.2
 ---> Using cache
 ---> 9a1f2e55d949
Step 8/17 : RUN curl -o invoiceninja.tar.gz -SL https://github.com/hillelcoren/invoice-ninja/archive/v${INVOICENINJA_VERSION}.tar.gz     && tar -xzf invoiceninja.tar.gz -C /var/www/     && rm invoiceninja.tar.gz     && mv /var/www/invoiceninja-${INVOICENINJA_VERSION} /var/www/app     && chown -R www-data:www-data /var/www/app     && composer install --working-dir /var/www/app -o --no-dev --no-interaction --no-progress     && composer require --working-dir /var/www/app omnipay/coinbase     && composer require --working-dir /var/www/app omnipay/paypal:~2.0     && chown -R www-data:www-data /var/www/app/bootstrap/cache     && mv /var/www/app/storage /var/www/app/docker-backup-storage     && mv /var/www/app/public /var/www/app/docker-backup-public     && rm -rf /var/www/app/docs /var/www/app/tests
 ---> Running in 2ea929029753
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   132    0   132    0     0    299      0 --:--:-- --:--:-- --:--:--   300
100   133    0   133    0     0    218      0 --:--:-- --:--:-- --:--:--   218
100 81.4M    0 81.4M    0     0  7169k      0 --:--:--  0:00:11 --:--:-- 8020k
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Installing dependencies from lock file
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.
Package operations: 194 installs, 0 updates, 0 removals
  - Installing symfony/polyfill-mbstring (v1.6.0): Downloading (100%)
  - Installing symfony/http-foundation (v3.1.10): Downloading (100%)
  - Installing symfony/event-dispatcher (v2.8.33): Downloading (100%)
  - Installing guzzle/guzzle (v3.9.3): Downloading (100%)
  - Installing omnipay/common (2.5.2): Downloading (100%)
  - Installing alfaproject/omnipay-skrill (dev-master f90a185): Downloading (100%)
  - Installing vlucas/phpdotenv (v2.4.0): Downloading (100%)
  - Installing symfony/var-dumper (v3.1.10): Downloading (100%)
  - Installing symfony/translation (v3.1.10): Downloading (100%)
  - Installing symfony/routing (v3.1.10): Downloading (100%)
  - Installing symfony/process (v3.1.10): Downloading (100%)
  - Installing psr/log (1.0.2): Downloading (100%)
  - Installing symfony/debug (v3.1.10): Downloading (100%)
  - Installing symfony/http-kernel (v3.1.10): Downloading (100%)
  - Installing symfony/finder (v3.1.10): Downloading (100%)
  - Installing symfony/console (v3.1.10): Downloading (100%)
  - Installing swiftmailer/swiftmailer (v5.4.8): Downloading (100%)
  - Installing paragonie/random_compat (v2.0.11): Downloading (100%)
  - Installing ramsey/uuid (3.7.2): Downloading (100%)
  - Installing nikic/php-parser (v3.1.3): Downloading (100%)
  - Installing jakub-onderka/php-console-color (0.1): Downloading (100%)
  - Installing jakub-onderka/php-console-highlighter (v0.3.2): Downloading (100%)
  - Installing dnoegel/php-xdg-base-dir (0.1): Downloading (100%)
  - Installing psy/psysh (v0.8.17): Downloading (100%)
  - Installing nesbot/carbon (1.22.1): Downloading (100%)
  - Installing mtdowling/cron-expression (v1.2.1): Downloading (100%)
  - Installing monolog/monolog (1.23.0): Downloading (100%)
  - Installing league/flysystem (1.0.41): Downloading (100%)
  - Installing symfony/polyfill-util (v1.6.0): Downloading (100%)
  - Installing symfony/polyfill-php56 (v1.6.0): Downloading (100%)
  - Installing jeremeamia/superclosure (2.3.0): Downloading (100%)
  - Installing doctrine/inflector (v1.2.0): Downloading (100%)
  - Installing classpreloader/classpreloader (3.2.0): Downloading (100%)
  - Installing laravel/framework (v5.3.31): Downloading (100%)
  - Installing anahkiasen/html-object (1.4.4): Downloading (100%)
  - Installing anahkiasen/former (4.1.6): Downloading (100%)
  - Installing asgrim/ofxparser (1.2.1): Downloading (100%)
  - Installing bacon/bacon-qr-code (1.0.3): Downloading (100%)
  - Installing barracudanetworks/archivestream-php (1.0.5): Downloading (100%)
  - Installing barryvdh/laravel-cors (v0.9.3): Downloading (100%)
  - Installing maximebf/debugbar (1.13.1): Downloading (100%)
  - Installing barryvdh/laravel-debugbar (v2.4.3): Downloading (100%)
  - Installing symfony/class-loader (v3.4.3): Downloading (100%)
  - Installing barryvdh/reflection-docblock (v2.0.4): Downloading (100%)
  - Installing barryvdh/laravel-ide-helper (v2.4.1): Downloading (100%)
  - Installing cerdic/css-tidy (v1.5.6): Downloading (100%)
  - Installing chumper/datatable (dev-develop 04ef2bf): Downloading (100%)
  - Installing sabre/uri (2.1.1): Downloading (100%)
  - Installing sabre/xml (1.5.0): Downloading (100%)
  - Installing cleverit/ubl_invoice (v1.0.1): Downloading (100%)
  - Installing psr/http-message (1.0.1): Downloading (100%)
  - Installing guzzlehttp/psr7 (1.4.2): Downloading (100%)
  - Installing guzzlehttp/promises (v1.3.1): Downloading (100%)
  - Installing guzzlehttp/guzzle (6.3.0): Downloading (100%)
  - Installing codedge/laravel-selfupdater (5.x-dev 084a1dd): Downloading (100%)
  - Installing collizo4sky/omnipay-wepay (dev-address-fix 942f3e0): Downloading (100%)
  - Installing delatbabel/omnipay-fatzebra (dev-master e78ac21): Downloading (100%)
  - Installing true/punycode (v2.1.1): Downloading (100%)
  - Installing league/url (3.3.5): Downloading (100%)
  - Installing dercoder/omnipay-paysafecard (dev-master 9fce03e): Downloading (100%)
  - Installing gocardless/gocardless-pro (1.4.0): Downloading (100%)
  - Installing digitickets/omnipay-gocardlessv2 (dev-payment-fix 4eb63d8): Downloading (100%)
  - Installing doctrine/cache (v1.6.2): Downloading (100%)
  - Installing doctrine/lexer (v1.0.1): Downloading (100%)
  - Installing doctrine/collections (v1.4.0): Downloading (100%)
  - Installing doctrine/annotations (v1.4.0): Downloading (100%)
  - Installing doctrine/common (v2.7.3): Downloading (100%)
  - Installing doctrine/dbal (v2.5.13): Downloading (100%)
  - Installing dwolla/omnipay-dwolla (dev-master f58af83): Downloading (100%)
  - Installing ezyang/htmlpurifier (v4.9.3): Downloading (100%)
  - Installing fzaninotto/faker (v1.7.1): Downloading (100%)
  - Installing gatepay/fedachdir (dev-master origin/master): Downloading    Failed to download gatepay/FedACHdir from dist: The "https://codeload.github.com/gatepay/FedACHdir/legacy.zip/origin/master" file could not be downloaded (HTTP/1.1 404 Not Found)
    Now trying to download from source
  - Installing gatepay/fedachdir (dev-master origin/master): Cloning origin/master
  - Installing phpseclib/phpseclib (2.0.9): Downloading (100%)
  - Installing psr/cache (1.0.1): Downloading (100%)
  - Installing firebase/php-jwt (v5.0.0): Downloading (100%)
  - Installing google/auth (v1.2.0): Downloading (100%)
  - Installing google/apiclient-services (v0.42): Downloading (100%)
  - Installing google/apiclient (v2.2.1): Downloading (100%)
  - Installing rize/uri-template (0.3.2): Downloading (100%)
  - Installing google/protobuf (v3.5.1.1): Downloading (100%)
  - Installing google/proto-client (0.29.0): Downloading (100%)
  - Installing grpc/grpc (1.6.0): Downloading (100%)
  - Installing google/gax (0.29.0): Downloading (100%)
  - Installing google/cloud (v0.51.0): Downloading (100%)
  - Installing intervention/image (dev-master a54d1e9): Downloading (100%)
  - Installing vink/omnipay-komoju (v1.0): Downloading (100%)
  - Installing softcommerce/omnipay-paytrace (v1.2.1): Downloading (100%)
  - Installing omnipay/stripe (dev-master 26a3341): Downloading (100%)
  - Installing omnipay/worldpay (v2.2.2): Downloading (100%)
  - Installing omnipay/targetpay (v2.2.1): Downloading (100%)
  - Installing omnipay/securepay (v2.1.1): Downloading (100%)
  - Installing omnipay/sagepay (2.5.1): Downloading (100%)
  - Installing omnipay/pin (v2.2.2): Downloading (100%)
  - Installing omnipay/paypal (v2.6.4): Downloading (100%)
  - Installing omnipay/paymentexpress (v2.2.1): Downloading (100%)
  - Installing omnipay/payflow (v2.3): Downloading (100%)
  - Installing omnipay/payfast (v2.1.3): Downloading (100%)
  - Installing omnipay/netbanx (v2.2): Downloading (100%)
  - Installing omnipay/netaxept (v2.3.0): Downloading (100%)
  - Installing omnipay/multisafepay (v2.3.6): Downloading (100%)
  - Installing omnipay/mollie (v3.2.0): Downloading (100%)
  - Installing omnipay/migs (v2.2.2): Downloading (100%)
  - Installing omnipay/manual (v2.2.1): Downloading (100%)
  - Installing omnipay/gocardless (dev-master f4f7079): Downloading (100%)
  - Installing omnipay/firstdata (v2.4.0): Downloading (100%)
  - Installing omnipay/eway (v2.2.1): Downloading (100%)
  - Installing omnipay/dummy (v2.1.2): Downloading (100%)
  - Installing omnipay/coinbase (v2.0.4): Downloading (100%)
  - Installing omnipay/cardsave (2.1.2): Downloading (100%)
  - Installing omnipay/buckaroo (v2.2.0): Downloading (100%)
  - Installing omnipay/authorizenet (dev-solution-id 56e9f74): Downloading (100%)
  - Installing omnipay/2checkout (dev-master b27d282): Downloading (100%)
  - Installing braintree/braintree_php (3.26.1): Downloading (100%)
  - Installing omnipay/braintree (dev-master 54846f2): Downloading (100%)
  - Installing omnipay/bitpay (dev-master 9cadfb7): Downloading (100%)
  - Installing mfauveau/omnipay-pacnet (2.0.4): Downloading (100%)
  - Installing meebio/omnipay-secure-trading (dev-master 370a795): Downloading (100%)
  - Installing meebio/omnipay-creditcall (dev-master b133a75): Downloading (100%)
  - Installing lokielse/omnipay-alipay (v1.4.13): Downloading (100%)
  - Installing justinbusschau/omnipay-secpay (2.0.6): Downloading (100%)
  - Installing fruitcakestudio/omnipay-sisow (v2.0.3): Downloading (100%)
  - Installing fotografde/omnipay-checkoutcom (2.1.1): Downloading (100%)
  - Installing dioscouri/omnipay-cybersource (dev-master b958302): Downloading (100%)
  - Installing digitickets/omnipay-realex (5.1.0): Downloading (100%)
  - Installing digitickets/omnipay-datacash (v3.0.0): Downloading (100%)
  - Installing digitickets/omnipay-barclays-epdq (3.0.0): Downloading (100%)
  - Installing descubraomundo/omnipay-pagarme (dev-master 99e92df): Downloading (100%)
  - Installing dercoder/omnipay-ecopayz (v1.0.2): Downloading (100%)
  - Installing cardgate/omnipay-cardgate (v2.0.0): Downloading (100%)
  - Installing andreas22/omnipay-fasapay (v1.0.2): Downloading (100%)
  - Installing agmscode/omnipay-agms (1.0.0): Downloading (100%)
  - Installing abdala/omnipay-pagseguro (0.2.0): Downloading (100%)
  - Installing invoiceninja/omnipay-collection (v0.6): Downloading (100%)
  - Installing jaybizzle/crawler-detect (v1.2.55): Downloading (100%)
  - Installing jaybizzle/laravel-crawler-detect (v1.2.0): Downloading (100%)
  - Installing zircote/swagger-php (2.0.13): Downloading (100%)
  - Installing jlapp/swaggervel (dev-master e026d72): Downloading (100%)
  - Installing twig/twig (v1.35.0): Downloading (100%)
  - Installing symfony/yaml (v3.3.15): Downloading (100%)
  - Installing symfony/filesystem (v3.4.3): Downloading (100%)
  - Installing symfony/dependency-injection (v3.2.14): Downloading (100%)
  - Installing symfony/config (v3.2.14): Downloading (100%)
  - Installing jakoch/phantomjs-installer (2.1.1): Downloading (100%)
  - Installing jonnyw/php-phantomjs (v4.5.1): Downloading (100%)
  - Installing laracasts/presenter (dev-master b284f31): Downloading (100%)
  - Installing laravel/legacy-encrypter (v1.0.0): Downloading (100%)
  - Installing league/oauth1-client (1.7.0): Downloading (100%)
  - Installing laravel/socialite (v2.0.21): Downloading (100%)
  - Installing laravelcollective/bus (v5.3.0): Downloading (100%)
  - Installing laravelcollective/html (v5.3.2): Downloading (100%)
  - Installing mtdowling/jmespath.php (2.4.0): Downloading (100%)
  - Installing aws/aws-sdk-php (3.49.0): Downloading (100%)
  - Installing league/flysystem-aws-s3-v3 (1.0.18): Downloading (100%)
  - Installing mikemccabe/json-patch-php (0.1.0): Downloading (100%)
  - Installing rackspace/php-opencloud (v1.16.0): Downloading (100%)
  - Installing league/flysystem-rackspace (1.0.5): Downloading (100%)
  - Installing league/fractal (0.13.0): Downloading (100%)
  - Installing symfony/css-selector (v3.4.3): Downloading (100%)
  - Installing tijsverkoyen/css-to-inline-styles (2.2.1): Downloading (100%)
  - Installing phpoffice/phpexcel (1.8.1): Downloading (100%)
  - Installing maatwebsite/excel (2.1.24): Downloading (100%)
  - Installing setasign/fpdi (1.6.2): Downloading (100%)
  - Installing mpdf/mpdf (v6.1.3): Downloading (100%)
  - Installing nwidart/laravel-modules (1.27.2): Downloading (100%)
  - Installing paragonie/constant_time_encoding (v2.2.0): Downloading (100%)
  - Installing twbs/bootstrap (v3.3.7): Downloading (100%)
  - Installing illuminate/html (v5.0.0): Downloading (100%)
  - Installing patricktalmadge/bootstrapper (5.5.3): Downloading (100%)
  - Installing pragmarx/google2fa (v2.0.7): Downloading (100%)
  - Installing pragmarx/google2fa-laravel (v0.1.4): Downloading (100%)
  - Installing predis/predis (v1.1.1): Downloading (100%)
  - Installing psr/container (1.0.0): Downloading (100%)
  - Installing simshaun/recurr (dev-master 7679f92): Downloading (100%)
  - Installing zendframework/zend-json (2.6.1): Downloading (100%)
  - Installing zendframework/zend-stdlib (3.1.0): Downloading (100%)
  - Installing container-interop/container-interop (1.2.0): Downloading (100%)
  - Installing zendframework/zend-validator (2.10.1): Downloading (100%)
  - Installing zendframework/zend-escaper (2.5.2): Downloading (100%)
  - Installing zendframework/zend-uri (2.5.2): Downloading (100%)
  - Installing zendframework/zend-loader (2.5.1): Downloading (100%)
  - Installing zendframework/zend-http (2.7.0): Downloading (100%)
  - Installing zendframework/zendservice-google-gcm (1.0.3): Downloading (100%)
  - Installing zendframework/zendservice-apple-apns (1.2.0): Downloading (100%)
  - Installing symfony/options-resolver (v3.4.3): Downloading (100%)
  - Installing turbo124/notification-pusher (v3.0.0): Downloading (100%)
  - Installing turbo124/laravel-push-notification (v2.0.0): Downloading (100%)
  - Installing webpatser/laravel-countries (dev-master 2568394): Downloading (100%)
  - Installing cedricziel/flysystem-gcs (v1.1.0): Downloading (100%)
  - Installing websight/l5-google-cloud-storage (dev-master ca2023b): Downloading (100%)
  - Installing wepay/php-sdk (0.2.7): Downloading (100%)
  - Installing wildbit/swiftmailer-postmark (2.1.0): Downloading (100%)
  - Installing wildbit/laravel-postmark-provider (dev-master 134f359): Downloading (100%)
Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.
Package chumper/datatable is abandoned, you should avoid using it. Use OpenSkill/Datatable instead.
Package league/url is abandoned, you should avoid using it. Use league/uri instead.
Package illuminate/html is abandoned, you should avoid using it. Use laravelcollective/html instead.
Generating optimized autoload files
> php artisan clear-compiled
The compiled class file has been removed.
> php artisan optimize
Generating optimized class loader
Compiling common classes
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Failed to clone the git@github.com:hillelcoren/omnipay-authorizenet.git repository, try running in interactive mode so that you can enter your GitHub credentials

  [RuntimeException]                                                                                                                                                           
  Failed to execute git clone --mirror 'git@github.com:hillelcoren/omnipay-authorizenet.git' '/root/.composer/cache/vcs/git-github.com-hillelcoren-omnipay-authorizenet.git/'  

require [--dev] [--prefer-source] [--prefer-dist] [--no-progress] [--no-suggest] [--no-update] [--no-scripts] [--update-no-dev] [--update-with-dependencies] [--update-with-all-dependencies] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--] [<packages>]...

The command '/bin/sh -c curl -o invoiceninja.tar.gz -SL https://github.com/hillelcoren/invoice-ninja/archive/v${INVOICENINJA_VERSION}.tar.gz     && tar -xzf invoiceninja.tar.gz -C /var/www/     && rm invoiceninja.tar.gz     && mv /var/www/invoiceninja-${INVOICENINJA_VERSION} /var/www/app     && chown -R www-data:www-data /var/www/app     && composer install --working-dir /var/www/app -o --no-dev --no-interaction --no-progress     && composer require --working-dir /var/www/app omnipay/coinbase     && composer require --working-dir /var/www/app omnipay/paypal:~2.0     && chown -R www-data:www-data /var/www/app/bootstrap/cache     && mv /var/www/app/storage /var/www/app/docker-backup-storage     && mv /var/www/app/public /var/www/app/docker-backup-public     && rm -rf /var/www/app/docs /var/www/app/tests' returned a non-zero code: 1
root@gitlab:/home/ninja/dockerfiles#

hillelcoren commented 6 years ago

I'm not sure, you may want to create an issue on the dockerfiles repo.

suculent commented 6 years ago

Dockerfiles repo inherits from latest release 4.2.2. It’s out of scope seems to me.

Odesláno z iPhonu

1. 2018 v 20:10, Hillel Coren notifications@github.com:

I'm not sure, you may want to create an issue on the dockerfiles repo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

hillelcoren commented 6 years ago

I'm not sure, none of the repos are private.

suculent commented 6 years ago

{

"type": "vcs",
"url": "https://github.com/hillelcoren/l5-google-cloud-storage"
},
{
"type": "vcs",
"url": "https://github.com/hillelcoren/omnipay-wepay"
},
{
"type": "vcs",
"url": "https://github.com/hillelcoren/omnipay-gocardlessv2"
},
{
"type": "vcs",
"url": "https://github.com/hillelcoren/omnipay-authorizenet"
}

suculent commented 6 years ago

Works after forking and redirecting original repos. But payment gateways are still wrong.

hillelcoren commented 6 years ago

What do you mean by "payment gateways are still wrong"?

The repositories listed are public repos created under my account.

invoiceninja / invoiceninja

PayPal Express with Braintree #1990