invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
53 stars 47 forks source link

Viewing the web version of an invoice sent to a client might mark the invoice as "Viewed" #1719

Closed nekohayo closed 4 months ago

nekohayo commented 4 months ago

In the v5 SaaS version,

For an already published/sent invoice,

  1. From inside the invoice editor, click the top-right menubutton
  2. Click "Client portal"

Result:

Impersonating a client for testing purposes should probably not write data like that, unless you're making a payment on their behalf or something...

turbo124 commented 4 months ago

The only way a document can trigger the logic to be marked as "viewed" is if the actual link from the invoice email is used.

I have not been able to replicate the description here by using any of the admin links / views for this.

nekohayo commented 4 months ago

Hmm... I have retested this with another invoice now, and you are correct that it does not get marked as read "through the client portal" if I impersonate a client via my own web interface.

My next hypothesis then is about something that might have gone wrong on my end when looking at the confirmation email that the platform sent to me (different from the one sent to the client), which looks roughly like this:

image

Originally my theory was that it must have been using the same link to the client's dashboard to view their invoice... but I see now that the one sent to me actually had an extra ?silent=true at the end, which I presume this is the part that makes it avoid marking the invoice as "Viewed".

I must have clicked that link, and I presume in theory it shouldn't have marked the invoice as viewed, so maybe somehow the extra URL parameter got stripped by my browser, I'm not sure why/how (it would sound a bit unlikely to me that uBlock Origin or CleanURLs would do this in this case). I was not able to properly test that hypothesis yet, because the client unexpectedly read the invoice I sent now, faster than I could test this!

turbo124 commented 4 months ago

Ok, please reopen if you can recreate this particular issue.