search

invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
53 stars 47 forks source link

[Bugfix] Mark Sent Action | Showing 422 In Toaster | Quotes #1723

Closed Civolilah closed 4 months ago

Civolilah commented 4 months ago

@beganovich @turbo124 The PR includes fixes for catching and displaying 422 in the toaster for the "mark_sent" action on Quotes. Let me know your thoughts.

Civolilah commented 4 months ago

@turbo124 In the ticket, you mentioned having an issue with not displaying the error messages for the "partial_due_date" and "due_date" properties. However, once I followed your guides, I was not able to find the actual issue, it looks like the error messages are properly displayed to me. Screenshot:

Screenshot 2024-04-22 at 18 30 24

Let me know your thoughts.

turbo124 commented 4 months ago

@Civolilah

The problem is when attempting to mark sent as a bulk action from the list view.

Civolilah commented 4 months ago

@Civolilah

The problem is when attempting to mark sent as a bulk action from the list view.

@turbo124 The logic we discussed today on Slack has been implemented. I've set up the global logic for handling toaster error messages whenever we receive a 422 error on NON-show and edit pages. Therefore, it should display the error message in the toaster every time we're not on the show or edit page. However, when we are on show/edit page, the error will simply be displayed under the specific field. Let me know your thoughts.