invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
52 stars 45 forks source link

[Cleanup] Updating Tinymce To 5.0.1 Version #1730

Closed Civolilah closed 2 months ago

Civolilah commented 2 months ago

@beganovich @turbo124 The PR includes updating the TinyMCE package to version 5.0.1, the latest available version. David, you mentioned in the ticket to update the package to v7, but the part of the package that we have installed is actually with 5 versions. The entire TinyMCE package (https://www.npmjs.com/package/tinymce) has 7 versions, but the version specifically installed for React (https://www.npmjs.com/package/@tinymce/tinymce-react) has 5 versions. The second package that we use is specifically for React and is much lighter, weighing only 99.9 kB, while the entire package is 8.28 MB. Therefore, I believe that the main reason for using only a part of the package is its size.

Once I updated the version, the "license_key" prop, which was previously set to "gpl", is no longer available to be set to that value. I believe they excluded this kind of handling for licenses. Currently, the value of this prop is optional, and the only value that can be set is "undefined". Therefore, I entirely removed this prop because it does not make sense to set it to "undefined" if it is optional, it will be "undefined" in both cases. (https://www.tiny.cloud/docs/tinymce/latest/license-key/)

I suppose this was the main reason for updating the package to the latest version?