invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
52 stars 45 forks source link

Product Cost not Accurately Displaying in Purchase Order #1747

Closed HiloKC closed 1 month ago

HiloKC commented 2 months ago

Current Situation:

Can't see anywhere in issues or documentation where this specific issue has been addressed.

The simple request here is for the purchase order to accurately pull up the product "Cost" so that PO with accurate cost can be sent to Vendor. The only workaround is to manually input the Cost in the the "Unit Cost" line (eg manually change cost from $1.001 to $0.7523). Is there a fix to ensure proper Unit Cost is displayed in the PO as well as ensuring cost can extend out 4 decimals rather than automatically round to 2 decimals (which causes large calculation errors in higher volume products)?

turbo124 commented 2 months ago

@Civolilah for purchase orders, if product cost > 0, then we should show item.product_cost instead of item.price

HiloKC commented 2 months ago

@turbo124 @Civolilah thanks for taking a look at this. Please note that now in the Invoice Ninja Mobile app, the product cost is correctly showing as the cost in new Purchase Orders created. However in the website (app.invoicing.co) the cost in new Purchase orders is still showing up incorrectly as the product price, not the cost.

Civolilah commented 2 months ago

@HiloKC Thanks for your advices! The issue will be fixed. However, you also mentioned rounding the unit_cost to more than 2 decimals, which is the default. In the Settings > User Details > Preferences > Number precision, there is an input field where you can specify the number of decimal places you want to round the unit_cost column to.

HiloKC commented 2 months ago

Thank you for the response!

Kevin S. Castle, PhD

Cofounder, SVP

Hilo Industries LLC

10432 Balls Ford Rd., Suite 300

Manassas, VA 20109


From: Abedin Halilovic @.> Sent: Tuesday, May 7, 2024 1:12:38 PM To: invoiceninja/ui @.> Cc: Kevin Castle @.>; Mention @.> Subject: Re: [invoiceninja/ui] Product Cost not Accurately Displaying in Purchase Order (Issue #1747)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

@HiloKChttps://github.com/HiloKC Thanks for your advices! The issue will be fixed. However, you also mentioned rounding the unit_cost to more than 2 decimals, which is the default. In the Settings > User Details > Preferences > Number precision, there is an input field where you can specify the number of decimal places you want to round the unit_cost column to.

— Reply to this email directly, view it on GitHubhttps://github.com/invoiceninja/ui/issues/1747#issuecomment-2099126708, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIKEN3QJS3SYTFYLHOEUPVDZBERSNAVCNFSM6AAAAABHJ3PPAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGEZDMNZQHA. You are receiving this because you were mentioned.Message ID: @.***>