search

invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
52 stars 45 forks source link

[Bugfix] Displaying Product Cost Instead Of Product Price | Purchase Orders Line Items | #1747 #1751

Closed Civolilah closed 2 months ago

Civolilah commented 2 months ago

@beganovich @turbo124 The PR includes logic changes for displaying the value in the unit_cost column. So, if product.cost is greater than zero (0), then the product.cost will be displayed in the unit_cost column instead of product.price. This will only happen for Purchase Orders. Let me know your thoughts.

Civolilah commented 2 months ago

@turbo124 I hope I understood the issue correctly and resolved it, but it seems that the same issue occurs on the Flutter web. Let me know your thoughts.

turbo124 commented 2 months ago

@Civolilah flutter handles this functionality correctly. for Purchase Orders only, we show the product cost rather than price.

Civolilah commented 2 months ago

@Civolilah flutter handles this functionality correctly. for Purchase Orders only, we show the product cost rather than price.

@turbo124 Ahamm, I adjusted that part of the logic. So currently, for the PO, if the cost is greater than zero, the unit_cost column will display the cost prop value instead of the price once you select the product. Please let me know if this is the correct behavior.