invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
55 stars 47 forks source link

Feature Request: UX: Button for reconnecting / refresh nordigen bank_integration #1770

Closed paulwer closed 4 months ago

paulwer commented 4 months ago

Hey folks, a while ago we implemented the new nordigen account integration, which can be configured via the settings. A bank_integration will expire after 90 days by default and the user have to refresh the integration.

Current Implementation

Right now, the user has to click connect new and select their institution and then follow the workflow.

Exspected Behavior

The user should have a button called refresh connection / refresh or simmilar, which opens the workflow to sign in again directly for him / her, skipping the bank-selection screen.

Suggested Solution

You should have to add a button on each bank_integration item within the list which

Changes in flutter-app

@hillelcoren is informed and is already working on this

Thank you all <3

turbo124 commented 4 months ago

@paulwer we use the onetime token for this currently, i would assume embedding the institution_id in that payload will have the same impact?

paulwer commented 4 months ago

yes it does.

turbo124 commented 4 months ago

@paulwer looking into this, i do not see a /connect endpoint, but i do see

createRequisition(config('ninja.app_url') . '/nordigen/confirm', $data['institution_id']

is this the correct one?

paulwer commented 4 months ago

sorry, the correct opening of the link is as follow:

url.de/nordigen/connect/?institution_id=xxxx

@hillelcoren also relevant for your implementation

hillelcoren commented 4 months ago

When using the /nordigen/connect route to initially connect I include the hash returned by the call to /one_time_token, for example: /nordigen/connect/$response['hash']

Do I need to do the same thing here, so the URL would be: /nordigen/connect/$response['hash']?institution_id=...

paulwer commented 4 months ago

From my pov yes, but please talk to David, he was about to do some changes here after some discussions today.

turbo124 commented 4 months ago

the route is /nordigen/connect/{onetimetoken}

so you would need to provide a onetime token with payload ['institution_id']

hillelcoren commented 4 months ago

Thanks! I've checked in a new Flutter web app and I'm working to release new mobile/desktop apps. When you have a chance please give it a try.

turbo124 commented 4 months ago

this also works as expected in React now, closing.