search

invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
52 stars 45 forks source link

[Feature] Implementing Links To Entities | Recurring Expenses #1775

Closed Civolilah closed 1 month ago

Civolilah commented 1 month ago

@beganovich @turbo124 The PR includes the implementation of icons on the left side that will navigate to the show pages of entities. In this case, for Recurring Expenses, the icons are implemented for the 'Vendor', 'Client', and 'Project' selectors. The icon will only be displayed if there is a selected value in the selector. Screenshot:

Screenshot 2024-05-26 at 23 50 44

Let me know your thoughts.

turbo124 commented 1 month ago

@Civolilah looks good, can we make these links open new tab instead of current tab please.

Civolilah commented 1 month ago

@Civolilah looks good, can we make these links open new tab instead of current tab please.

@turbo124 Sure thing, it is implemented that way, so the entity's page will open in a new tab. Let me know your thoughts.

turbo124 commented 1 month ago

@Civolilah i''m seeing a issue locally when clicking on this, it appears to lose the /#/ in the URL ? and does not work like other internal links in the application.

Civolilah commented 1 month ago

@Civolilah i''m seeing a issue locally when clicking on this, it appears to lose the /#/ in the URL ? and does not work like other internal links in the application.

@turbo124 Ah, okay. The issue was only with the hash router, but I tested with the browser only. I've fixed it. Let me know your thoughts.