search

invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
52 stars 46 forks source link

[Feature] Implementing "Entity Type" and "Entity Id" Selectors | Custom Designs #1785

Closed Civolilah closed 1 month ago

Civolilah commented 1 month ago

@beganovich @turbo124 The PR includes the implementation of new selectors for custom_designs: the selector for entity_type and selectors for selecting specific entities. Screenshot:

Screenshot 2024-06-01 at 09 40 23

Note: I used the "entity" translation keyword in the first selector. We are missing this translation keyword from the files, so if you agree, please just add it there.

Let me know your thoughts.

turbo124 commented 1 month ago

@Civolilah please change prop entity_type => entity

Civolilah commented 1 month ago

@Civolilah please change prop entity_type => entity

@turbo124 Sure, it has been changed. Screenshot:

Screenshot 2024-06-02 at 17 12 27

Let me know your thoughts.

Civolilah commented 1 month ago

@turbo124 As we discussed in slack, the prop name is changed from entity_type to entity. Let me know your thoughts.