invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
52 stars 46 forks source link

Reset counter did not execute #1822

Open DrDBanner opened 3 weeks ago

DrDBanner commented 3 weeks ago

Setup

Interface

Checklist

Describe the bug

The automatic counter reset was set to monthly but did not reset as expected. Should have executed on the 1st of june at 0:00:01 I guess.

Expected Behavior

Reset counter.

Additional context

No

Screenshots

Bildschirmfoto 2024-06-10 um 10 51 15 Bildschirmfoto 2024-06-10 um 10 50 45 Bildschirmfoto 2024-06-10 um 10 50 27
turbo124 commented 2 weeks ago

This is localized to your timezone, has it still not run?

DrDBanner commented 2 weeks ago

Didn't run so far. I set it once on the 5th of May. Since then untouched. Just observed it didn't run.

Bildschirmfoto 2024-06-12 um 09 46 18 Bildschirmfoto 2024-06-12 um 09 47 11
turbo124 commented 2 weeks ago

image

This looks odd. There is no date selector and the date appears greyed out

turbo124 commented 2 weeks ago

So it did reset? You have the 10th of june selected as the date?

DrDBanner commented 2 weeks ago

This field shows my current date. Today it shows the 13th of june. A Date selector appears if I click into the field. When I initially set it to monthly there's a chance I did not put in any date to 'Next Reset'. I can't remember. If so, my expectation was most likely it would determine the date on it's own as long as I do not put any different date. Seems like the documentation doesn't cover what's mandatory here. Wouldn't it be ideal if I change the 'Reset Counter' value the 'Next Reset' date gets determined based on what I choose from on 'Reset Counter'? At least it should be covered when I do not put a date into 'Next Reset' nothing will happen.

turbo124 commented 2 weeks ago

The date in the reset counter indicates the next time that the reset date counter will be performed. Once it is triggered. A new date is inserted.

DrDBanner commented 2 weeks ago

Do you want me to do anything specific now?

turbo124 commented 2 weeks ago

@DrDBanner If you want the counter to reset on the 1st of July. Set the reset date to there. Let us know if the counter does not reset as expected after that date.

DrDBanner commented 2 weeks ago

In a different installation I have noticed that I set a date there and it was saved. So, I guess in this installation I did not set any date at all. We can argue now who's right. At least I find the userinterface unclear, as well as the documentation in this particular case. So, perhaps adding a one-liner to the documentation, or a one liner to the interface may fix already the issue. Alternatively, making the field mandatory once anything other than 'never' is selected in the interval field.

DrDBanner commented 2 weeks ago

leave open or close this issue?