invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
55 stars 47 forks source link

React web app in new version 5.9.4 always uses default quantity of zero #1843

Closed Plaschke-Culturall closed 2 months ago

Plaschke-Culturall commented 3 months ago

Hi!

We recently upgraded our self-hosted installation to v5.9.4. and I wanted to test the react web app.

In the product settings we usually disable "Show Product Quantity" and set the default quantity to one. (We don’t deal with product quantities and we don’t show them on the invoices). This works fine in the old flutter web interface but when I switch to the new react web app, it still shows the product quantity when creating a new invoice and this quantity is always set to zero.

How can we get rid of product quantities again? Or at least have a default value of always one?

turbo124 commented 3 months ago

image

if you toggle default quantity to on, does this auto set the quantity to 1 for you?

Plaschke-Culturall commented 3 months ago

No, this property seems to get ignored, no matter what I select.

I now also have bugs with the tax-rate for items. The tax-rate that is shown in the drop-down menu after selecting one (when adding a new item) is different than the tax-rate I selected (and that is applied on the invoice).

Maybe I should just first try to somehow update my installation to the most current version v5.9.9.

LarsK1 commented 3 months ago

Can confirm this one as well.

turbo124 commented 3 months ago

https://www.loom.com/share/781c0ba678984adb90fc853b35f576fc?sid=b694301b-a8cc-4367-a052-ffb97eec74b9

Just to confirm, in the react app the product quantities are only hidden in the product edit page. The quantity may still display on the invoice edit form, however it will default to 1.

Are you seeing something different to this?

LarsK1 commented 3 months ago

@turbo124 this is my default window, after adding a single line item image

turbo124 commented 3 months ago

@LarsK1

And after you select a product?

LarsK1 commented 3 months ago

@turbo124 then it automatically set's the quantity to 1. But the request is, which makes sense to me as well to set the quantity to 1, even without a product selected. As many (so do I) don't create a product for each item, which is sold (maybe only once).

Plaschke-Culturall commented 2 months ago

Yes, exactly. We don't create a product for each item, because we basically have different line items everytime we issue an invoice. So if I write a new invoice with e.g. 10 items I have to manually insert the quantity 1 everywhere, even though we don't use quantities on our invoices.

In the old app there was not even a field to set a quantity if you had "Show Product Quantity" unchecked in the product settings.

For us this would be the most convenient solution, to not have the field there on the create invoice page. Or just set it to the default value of 1 instead of 0.00 (if that is selected in the product settings).

Not that this is a huge issue, it's just slightly annoying ;-)

turbo124 commented 2 months ago

@Civolilah the task here is that when a new line item is clicked (+) if Set product default quantity is set to 1, then we inject 1 into quantity