invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
52 stars 46 forks source link

Hide new user option when selecting user for Gmail/Microsoft Sending. #1857

Open dylanh724 opened 1 week ago

dylanh724 commented 1 week ago

Setup

Hosted with you. Web app only (since no desktop support, it seems).

Describe the bug

When I choose GMail (OAuth) email provider user, the dropdown says the list is empty. I expected to find my own (since I login with Gmail - it's already connected).

When I go to the only option (new user), I'm asked to upgrade to enterprise, detecting it as a completely different user. I should be able to select the user I'm already logged in with (or asked to connect my gmail, if not already connected).

Steps To Reproduce

  1. https://app.invoicing.co/#/settings/email_settings
  2. Email provider == Gmail (OAuth)
  3. Dropdown gmail user

OAuth is the recommended flow rather than smtp, so smtp is probably the temporary workaround.

Expected Behavior

I should be able to add my own user rather than forced to arbitrarily create another new user.

Screenshots

image

turbo124 commented 1 week ago

image

You authenticate in Settings > User Details OAuth/Mail

The react app will then ask if you want to select this user as the sending user.

dylanh724 commented 1 week ago

Thanks; ah, then perhaps this issue should more be a feat request -- if existing user doesn't have a connection, link to this page. Having no info just looks like a bug. New ticket, or edit?

turbo124 commented 1 week ago

image

We should not show the new user option here when selecting the sending user.