Task time total in edit view loops around after 24h

thirstyice commented 1 month ago

Setup

Version: v14.04.2024.1, API: 5.10.4
Environment: ZIP

Interface

Flutter: [] (N/A, total time not shown in flutter edit view)
React: [x]
Both: []

Checklist

Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo?
Yes
Have you searched existing issues?
Yes
Have you reported this to Slack/forum before posting?
No
Have you inspected the logs in storage/logs/laravel.log for any errors?
No, I doubt this is the kind of thing that would be logged

Describe the bug

When editing a task in the react app, the total time (shown beside the start stop / play pause button) is incorrect when the total time is greater than 24h, showing instead the total time mod 24h (25h shows as 1h, 50h as 2h, etc)

Steps To Reproduce

Create a task. Edit the task such that the total tome logged is greater than 24h Observe

Expected Behavior

The total duration to show the total duration, even when that is longer than 24h

turbo124 commented 1 month ago

@Civolilah in Carbon there is an option to have a human readable time. I think we'll want to use the dayjs equivalent to present time frame in days / hrs ... but only after the first 24hrs has completed.

thirstyice commented 1 month ago

For what it's worth, I'd actually prefer it if it just kept counting up hours (23->24->25->etc.)

I'm often given a budget for a given project of a set number of hours (say, 40h over 2 weeks), and it's handy to be able to see how close I am to that limit without doing math to convert days back to hours.

invoiceninja / ui