invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
57 stars 48 forks source link

Cannot reliably update names of items on the fly #1938

Closed itkfm closed 3 months ago

itkfm commented 3 months ago

In the React frontend, it’s not always possible to rename items. The updated name is not used for the PDF. Nor does it get saved when hitting the save button. …When this happens.

Workaround

One has to delete the item from the quote and add a new one with the same data but the correct name.

Screenshot + steps

Please note that this does not occur all the time.

See this screenshot taken on react.invoicing.co.

  1. Create new quote.
  2. Add item with a wrong name was created (“Gulasch” in the case of the screenshot).
  3. Hit [Save]
  4. Rename the item. (Maybe to “Gulasch 2”.)
  5. Hit [Save]
  6. The change is neither reflected in the PDF preview nor in the quote.

image

itkfm commented 3 months ago

Hint: There’s a higher chance to reproduce it, when you leave the item-name field by a mouse click than using the keyboard.

itkfm commented 3 months ago

image

itkfm commented 3 months ago

Looks like a databinding is not triggered when you leave the field by clicking somewhere else on the page.


I recommend clicking somewhere here for more reliable reproduction of the issue: image

turbo124 commented 3 months ago

I can recreate this.

@Civolilah steps to reproduce enter in any data into the line items.

Then remove some characters just from the Item field and click save. The PUT request contains the old data, not the updated item text.