invoiceninja / ui

Invoice Ninja: Web admin portal built with React
https://app.invoicing.co
Other
57 stars 48 forks source link

Wrong duration formatting in invoice with task details #2057

Open cdahinten opened 1 month ago

cdahinten commented 1 month ago

Setup

Interface

Checklist

Describe the bug

Setting localisation like this: Bildschirmfoto 2024-09-17 um 11 46 02 Task settings like this: Bildschirmfoto 2024-09-17 um 11 46 58 Results in Invoice-Details like this (should be "2,25 Stunden" instead of "2.2500 Stunden") wrong decimal-separator, too many decimals: Bildschirmfoto 2024-09-17 um 11 51 43 Bildschirmfoto 2024-09-17 um 12 07 59

Steps To Reproduce

setup like screenshots above

Expected Behavior

Formatting should be e.g "2,25 Stunden" instead of "2.2500 Stunden"

Additional context

The react backend has no option to influence this behaviour probably (see flutter backend): Bildschirmfoto 2024-09-17 um 12 50 39 The Linux App of which I guess is flutter-based works also not as expected – and not stable enough (Ubuntu 24.04.1 LTS, IN 5.0.158). It delivers mixed results: Bildschirmfoto vom 2024-09-17 13-26-41

Screenshots

-above-

Logs

-don't contribute to the problem.

turbo124 commented 4 weeks ago

@Civolilah please ensure client localized number formatting for the duration of task

cdahinten commented 4 weeks ago

Thank you, @turbo124 the localized formatting should also work in "Reports" section (Screenshots). This formatting issue leads to difficulties in number recognition e.g. here in latest LibreOffice. The Item description should contain the clean Text – not the markup-Version. Therefore the CSV gets really heavy to clean out. What do you think?

Bildschirmfoto 2024-09-19 um 15 31 08 Bildschirmfoto 2024-09-19 um 15 30 35 Bildschirmfoto 2024-09-19 um 15 32 39 Bildschirmfoto 2024-09-19 um 15 36 21

turbo124 commented 4 weeks ago

@Civolilah

The preview should provide a formatted export matching the company currency

turbo124 commented 4 weeks ago

@cdahinten are you able to create this as a separate issue so we can track these separately please?