involveMINT / iMPublic

Public involveMINT repo #hacktoberfest
https://app.involvemint.io
7 stars 20 forks source link

As a ServeAdmin, (admin of a project), the app kept flagging me errors about the changemaker applying for the project not being approved because their application was incomplete despite the changemaker having their project application completed and an already approved poi Clock in location displayed on serveadmin view under "activity" tab #218

Open QuinnNTonic opened 4 months ago

QuinnNTonic commented 4 months ago

Repro Steps

The app kept flagging me errors about the changemaker being not approved because their application was incomplete despite the changemaker having the application completed and approved poi Clock in location displayed on serveadmin
QuinnNTonic commented 4 months ago

Original Work Item URL

Original Work Item Details

| Created date | Created by | Changed date | Changed By | Assigned To | State | Type | Area Path | Iteration Path| |---|---|---|---|---|---|---|---|---| | 12/16/2021 02:46:07 | info | 05/19/2024 22:47:06 | info | Kenny Wu | New | Bug | involveMINT\involveMINT | involveMINT\72 |

Original Work Item JSON

```json { "fields": { "Microsoft.VSTS.Common.Priority": 4, "Microsoft.VSTS.Common.StackRank": 999192308, "Microsoft.VSTS.Common.StateChangeDate": "12/16/2021 02:46:07", "System.AssignedTo": { "displayName": "Kenny Wu" }, "System.BoardColumn": "New", "System.BoardColumnDone": False, "System.ChangedBy": { "displayName": "info" }, "System.ChangedDate": "05/19/2024 22:47:06", "System.CommentCount": 0, "System.CreatedBy": { "displayName": "info" }, "System.CreatedDate": "12/16/2021 02:46:07", "System.Id": 503, "System.Reason": "New", "System.Rev": 6, "System.RevisedDate": "01/01/9999 00:00:00", "System.State": "New", "System.TeamProject": "involveMINT", "System.Title": "The app kept flagging me errors about the changemaker being not approved because their application was incomplete despite the changemaker having the application completed and approved poi Clock in location displayed on serveadmin", "System.WorkItemType": "Bug", "WEF_F54671B39AF54036B4485F04394D6594_Kanban.Column": "New", "WEF_F54671B39AF54036B4485F04394D6594_Kanban.Column.Done": False, "WEF_F54671B39AF54036B4485F04394D6594_System.ExtensionMarker": True }, "id": 503, "relations": [ ], "rev": 6, "url": "https://dev.azure.com/involvemint/1853e4bf-a341-4c37-98f5-57387729b589/_apis/wit/workItems/503" } ```

involve-MINT commented 3 months ago

@sakshamg19 @QuinnNTonic @fogunsan this ticket may be initially resolved by making it optional to require the serveadmin (Project admin) to approve changemaker applications for a project. This is functionality we want to add anyways. We may jsut make a little toggle for requiring admin approval on applications on the project edit page (servepartner)