involveMINT / iMPublic

Public involveMINT repo #hacktoberfest
https://app.involvemint.io
7 stars 20 forks source link

Photo aspect ratios are off #270

Closed involve-MINT closed 3 months ago

involve-MINT commented 4 months ago

When viewing from the marketplace, photos get cut off on the tile standpoint, we need to resize the image appropriately so it fits within the tile.

b3nkang commented 3 months ago

Edit: Ignore, this comment is out-of-date now

While completing this task I ran across a larger issue with the image uploading-

When creating a ServePartner project listing or ExchangeProvider storefront on marketplace, the image upload functionality does not work - when in the image upload region (both the storefront image upload and project info), after uploading, a small loading modal pops up and says upload completed 100% and then disappears. However, the image upload square turns black continues buffering with a green loading circle indefinitely (even after navigating away and back to the storefront/project). Image does not display and the project listing/marketplace storefront instead shows a blank listing or storefront.

ServePartner examples:

Image

Image

ExchangeProvide examples:

Image

Image

b3nkang commented 3 months ago

Fix for the image loading in prev. comment involved replacing gcp and firebaseEnv in environment.local.ts to be hooked up to imPublic instance.

Fix for the images (task itself):

Before:

Image

After:

Image

(Identical to behaviour in the im-image component)