search

involveMINT / iMPublic

Public involveMINT repo
https://app.involvemint.io
7 stars 20 forks source link

As a user I shouldn't be allowed to send negative credits #288

Open involve-MINT opened 1 month ago

fogunsan commented 3 weeks ago

rough code location: /involvemint/iMPublic/libs/client/shell/src/lib/wallet/wallet.component.html To confirm: Is the code change to ensure that a negative balance doesn't show up on the UI? The current behavior is that it is not permitted to send credits when balance is 0, but @samanthap88 can also try testing when there are more than zero credits and the amount you want to send is greater than the balance to ensure that this is not permitted.

Image

involve-MINT commented 3 weeks ago

@sakshamg19 @fogunsan yes we want to ensure a negative balance does not show up on the UI.

In the future, we want to consider allowing negative balance in the form of a "request" but that is not part of the scope of what we are doing now. I only say this for your future consideration when writing your code.