invopop / gobl

Go Business Language
Apache License 2.0
92 stars 8 forks source link

Normalizing ExtMap, Stamps, and others to remove empty rows #250

Closed samlown closed 8 months ago

samlown commented 8 months ago
samlown commented 8 months ago

I still find surprising ExtMap is under tax and not under a more generic package such us cbc, but I believe we already had and settled that discussion.

I think the main confusion there is with the values, I'm not happy with the KeyOrCode type. I'm tempted to convert it into a string without strict validation: most extensions have a fixed list of constants anyway.

I'm also tempted to rename into simply Extensions instead of ExtMap. That way the implications of tax.Extensions is way more obvious.