search

invopop / gobl

Go Business Language
Apache License 2.0
92 stars 8 forks source link

Add UUIDv3 creation functions #253

Closed cavalle closed 8 months ago

cavalle commented 8 months ago
cavalle commented 8 months ago

I think I'd suggest adding some tests for these cases! :-) Since we're here, it might also make sense to support UUIDv5, and also add some comments about the differences. (v3 is faster, but less secure apparently)

Thanks! I'll do all that

cavalle commented 8 months ago

@samlown I addressed your feedback in https://github.com/invopop/gobl/pull/253/commits/3ebd1c20f1786fe92632f0218e503176e7ac0bda. I'm merging now, but do not hesitate to let me know if you have any additional comment.

cavalle commented 8 months ago

Just realised the comments aren't correct. A hash can never be "reversed", I'll fix it

cavalle commented 8 months ago

Fixed in: b90dc64