search

inway / mojo-rabbitmq-client

Mojo::IOLoop based RabbitMQ (AMQP) client
Artistic License 2.0
15 stars 17 forks source link

Circular includes #20

Closed christopherraa closed 6 years ago

christopherraa commented 6 years ago

In some of the modules in this dist there are circular includes. Specifically this is due to the user of use in Mojo::RabbitMQ::Client, Mojo::RabbitMQ::Client::Consumer and Mojo::RabbitMQ::Client::Publisher;

$ for file in $( find lib/ -type f ); do perl -Ilib -c $file; done
Subroutine connect redefined at lib/Mojo/RabbitMQ/Client.pm line 47.
Subroutine connect_p redefined at lib/Mojo/RabbitMQ/Client.pm line 58.
Subroutine consumer redefined at lib/Mojo/RabbitMQ/Client.pm line 80.
Subroutine publisher redefined at lib/Mojo/RabbitMQ/Client.pm line 87.
Subroutine param redefined at lib/Mojo/RabbitMQ/Client.pm line 94.
Subroutine add_channel redefined at lib/Mojo/RabbitMQ/Client.pm line 100.
Subroutine acquire_channel_p redefined at lib/Mojo/RabbitMQ/Client.pm line 132.
Subroutine open_channel redefined at lib/Mojo/RabbitMQ/Client.pm line 147.
Subroutine delete_channel redefined at lib/Mojo/RabbitMQ/Client.pm line 159.
Subroutine close redefined at lib/Mojo/RabbitMQ/Client.pm line 164.
Subroutine _loop redefined at lib/Mojo/RabbitMQ/Client.pm line 181.
Subroutine _error redefined at lib/Mojo/RabbitMQ/Client.pm line 183.
Subroutine _uri_handler redefined at lib/Mojo/RabbitMQ/Client.pm line 189.
Subroutine _close redefined at lib/Mojo/RabbitMQ/Client.pm line 261.
Subroutine _handle redefined at lib/Mojo/RabbitMQ/Client.pm line 266.
Subroutine _read redefined at lib/Mojo/RabbitMQ/Client.pm line 274.
Subroutine _parse_frames redefined at lib/Mojo/RabbitMQ/Client.pm line 308.
Subroutine _connect redefined at lib/Mojo/RabbitMQ/Client.pm line 352.
Subroutine _connected redefined at lib/Mojo/RabbitMQ/Client.pm line 392.
Subroutine _tune redefined at lib/Mojo/RabbitMQ/Client.pm line 451.
Subroutine _write_expect redefined at lib/Mojo/RabbitMQ/Client.pm line 511.
Subroutine _expect redefined at lib/Mojo/RabbitMQ/Client.pm line 530.
Subroutine _write_frame redefined at lib/Mojo/RabbitMQ/Client.pm line 575.
Subroutine _write redefined at lib/Mojo/RabbitMQ/Client.pm line 588.
Subroutine DESTROY redefined at lib/Mojo/RabbitMQ/Client.pm line 601.
lib/Mojo/RabbitMQ/Client.pm syntax OK
lib/Mojo/RabbitMQ/Client/Method.pm syntax OK
lib/Mojo/RabbitMQ/Client/Method/Publish.pm syntax OK
lib/Mojo/RabbitMQ/Client/Publisher.pm syntax OK
lib/Mojo/RabbitMQ/Client/Consumer.pm syntax OK
lib/Mojo/RabbitMQ/Client/LocalQueue.pm syntax OK
lib/Mojo/RabbitMQ/Client/Channel.pm syntax OK

The code works as intended but any application that does linting, syntax checking etc will complain. An example of this is IDE's where the message would appear as an issue to be adressed. Example screenshot from Emacs:

2018-01-20-091627_597x125_scrot