search

inwc3 / JMPQ3

Native Java mpq archive library
Apache License 2.0
38 stars 17 forks source link

MPQ file manipulation tests do not check if files were manipulated. #16

Closed DrSuperGood closed 7 years ago

DrSuperGood commented 7 years ago

The tests do not check if any files were manipulated. When there was an error in the file key generation algorithm the result was that all tests passed because there were no files in any of the MPQs. Reading files from the test MPQs should verify they exist after extraction and also that the extracted content matches a sha-1 hash of the expected content.

Frotty commented 7 years ago

True. Especially also files being the same after write->extract was crucial for finding some other bugs. I assign this to me if you don't mind.