Closed PhoenixZeng closed 4 years ago
Thanks for your contribution. Please get rid of whitespace changes and add unit tests for the new features.
There are still some weird whitespace and formatting issues, other than that looks good.
still has a bunch of formatting issues, otherwise looks fine ithink
please show me the formatting issue
. I cant find it
ideally u should be using the IDEA formatter on ur changed code:
insertByteArray(name,input,false);
-> insertByteArray(name, input, false);
mpqEditor.getMpqFilesByBlockTable().size()>0
-> mpqEditor.getMpqFilesByBlockTable().size() > 0
){
-> ) {
etc.
it`s hard for me. cause i changed the idea default setting.
I've tried my best. I don't want to change it if I still have format problems I am willing to comply with most of the format requirements, such as indentation and common format requirements Excessive format requirements will reduce other's desire for pr
How do you decide what's not common? I think it is very basic that contributed code conforms to the standards of the existing code base. I might check out the branch later.
Using IntelliJ's default autoformat uses spaces but is messing with the current JavaDoc format:
It seems like the "Do not wrap one line comments" under File | Settings | Editor | Code Style | Java | JavaDoc | Other seems to do the trick. For now, I've created a pull request for your fork. In the future, please restore the default IDEA Code Style settings (just for this project) and tic the checkbox mentioned before. Then autoformat your code using:
For Windows : Ctrl + Alt + L
For Ubuntu : Ctrl + Alt + Windows + L
For Mac : ⌥ (Option) + ⌘ (Command) + L
@Crigges use the function to "only format changed lines".
Thanks for your contribution 👍
Coverage increased (+0.3%) to 85.928% when pulling 86d8a461b7f81d590f4fd0569a732be0f4652e87 on PhoenixZeng:master into d782af04be23c605f646630179558724bd5e64e1 on inwc3:master.