Allow usage of external Listfile to rebuild MPQ.

inwc3 / JMPQ3

Native Java mpq archive library

Apache License 2.0

38 stars 17 forks source link

Allow usage of external Listfile to rebuild MPQ. #36

Closed zach-cloud closed 3 years ago

zach-cloud commented 4 years ago

By calling the addExternalListfile method, allows JMPQ3 to write archives that were missing (listfile)
Refactored code that was going to be common between the addExternalListfile method and the internal readListfile

coveralls commented 4 years ago

Coverage decreased (-0.4%) to 85.503% when pulling 5b6e5a8db2a9be327609b07582b85ec25f0a906f on zach-cloud:master into 7e87dc95e8b03df0397c0aca34fa74a1d366677b on inwc3:master.

Frotty commented 4 years ago

Thanks for your contribution 😃 I added a couple comments, otherwise looks good. The hiddenFile count was never working reliably iirc, should probably check up on that. e: Ok I fixed travis integration. The Test fails currently.

zach-cloud commented 4 years ago

Ah, found why the test failed :) Fixed that.

Frotty commented 4 years ago

Status?

zach-cloud commented 4 years ago

Status?

Sorry for the delays. Been very busy lately. I've re-tested and confirmed it does work without the removeMissingFiles method, so I've deleted this. Should be good to go anyways

Frotty commented 3 years ago

Sry for not merging, thanks for the contribution.