search

inwc3 / w3-bug-tracker

Bug tracker for Warcraft 3
0 stars 0 forks source link

war3mapUnits.doo changed, format version not changed #10

Open WaterKnight opened 1 year ago

WaterKnight commented 1 year ago

External URLs

https://us.forums.blizzard.com/en/warcraft3/t/war3mapunitsdoo-changed-format-version-not-changed/29081

Summary

The format of the war3mapUnits.doo file inside map archives has been changed as of 1.32 to additionally feature a “skinId” attribute per unit/item object. But the version/sub version numbers after the “W3do” start marker have not been increased, i.e., to parse the file properly, additional context information is needed now, i.e., one needs to know what game version the war3mapUnits.doo was saved with as found in the war3map.w3i.

Description

This breaks existing libraries/tooling which handle war3mapUnits.doo as a standalone file.

Expected

The format version should be increased to indicate the different format. If the indication should now be using the war3map.w3i in general instead, then at least change the specified format version in the war3mapUnits.doo one last time, maybe to 0x0 in order to indicate that it is not self-sufficient anymore and in order to not break backwards compatibility.

Actual

No response

Reproduction steps

No response

Workaround

No response

Screenshots

No response

Game Versions

1.33.0 (1.33.0.18931, 1.33.0.19010, 1.33.0.19019, 1.33.0.19089, 1.33.0.19308)

cipherxof commented 1 year ago

Even maps with format version 25 (TFT) can use Reforged doo files as can be seen here: https://cdn.discordapp.com/attachments/1037954156708773929/1053586405441417266/DotA_LoD_2.1e1.w3x