search

inwc3 / wc3libs

Java library for reading and modifying Warcraft III maps and game files
Apache License 2.0
31 stars 11 forks source link

log the base directory when searching all sub-paths for wc3 exe #73

Closed Cokemonkey11 closed 2 years ago

Cokemonkey11 commented 3 years ago

In the current version of code, the exception here logs all the paths that wc3libs tries, but it doesn't mention the base path that was requested.

For debugging https://github.com/wurstscript/WurstScript/issues/1034, it seems more valuable to see what base path was provided by consumer. It is no longer useful to log the "paths tested" since we know that part to be working.

codecov-commenter commented 3 years ago

Codecov Report

Merging #73 (32c79c0) into master (7ece74a) will decrease coverage by 0.00%. The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     40.88%   40.88%   -0.01%     
  Complexity     1718     1718              
============================================
  Files           432      432              
  Lines         21771    21773       +2     
  Branches       1777     1775       -2     
============================================
  Hits           8902     8902              
- Misses        12336    12338       +2     
  Partials        533      533
Impacted Files Coverage Δ
...oonlightflower/wc3libs/port/NotFoundException.java 33.33% <0.00%> (-16.67%) :arrow_down:
...lightflower/wc3libs/port/win/WinGameExeFinder.java 22.41% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ece74a...32c79c0. Read the comment docs.