Webpack warning: Critical dependency: the request of a dependency is an expression

inxilpro / node-app-root-path

Determine the root path to your project

MIT License

604 stars 29 forks source link

Webpack warning: Critical dependency: the request of a dependency is an expression #30

Closed nickforddev closed 5 years ago

nickforddev commented 6 years ago

https://github.com/webpack/webpack/issues/196

in ./node_modules/app-root-path/browser-shim.js
Critical dependency: the request of a dependency is an expression

It's not a catastrophic error but it is pretty unfortunate having to filter this error in all of my webpack projects that use it.

PaulTondeur commented 5 years ago

Would be good if this issue could be resolved.

inxilpro commented 5 years ago

Can y'all give me more details or steps to reproduce?

d-pollard commented 5 years ago

@inxilpro if you use the vue-cli to create a new app: vue create some-app then install this repo, import it in a file and you'll see the error specified

inxilpro commented 5 years ago

Version 2.2.0 should address this issue, although this package really doesn't make sense in the context of webpack, so it might be better to remove the browser-shim altogether down the road.