search

inxilpro / node-app-root-path

Determine the root path to your project
MIT License
605 stars 29 forks source link

Incompatible with Browserify #42

Open Bluebie opened 4 years ago

Bluebie commented 4 years ago

Browserify 16.5.0 does not seem to provide a .main property on the require object, so requiring app-root-path is failing because browser cannot read property .filename from require.main (which is undefined)

https://github.com/inxilpro/node-app-root-path/blob/54d06fef2340a36070fbfc24973bb676079aa7a1/browser-shim.js#L3

22 seems to be related to the same problem, but was closed without any more information about why.

You can reproduce breaking browserify with:

echo "console.log(require('app-root-path').toString())" > test.js
browserify test.js -o bundle.js

and then trying to load bundle.js with a script tag in a browser.

inxilpro commented 3 years ago

Would you be willing to submit a PR for the browser shim?