search

inxomnyaa / MagicWE

Lag free asynchronous world editor for PMMP with plenty of options
https://poggit.pmmp.io/ci/inxomnyaa/MagicWE
GNU General Public License v3.0
101 stars 83 forks source link

[10.0.2] Duplicate Exclamation Mark #180

Closed Nerahikada closed 3 years ago

Nerahikada commented 4 years ago

Description

The exclamation mark in the message is duplicated. This affects translation. temp

MagicWE2 v10.0.2 Information
Website https://github.com/thebigsmileXD/MagicWE2
Version 10.0.2
Plugin API Version 3.9, 3.10, 3.11
Authors XenialDan
Enabled Yes
Uses UI No
Phar Yes
PMMP Protocol Version v1.14.0
PMMP Version 3.11.6
PMMP API Version 3.11.6
Aericio commented 4 years ago

Location: https://github.com/thebigsmileXD/MagicWE2/blob/f102dddd7c580ac728cd13b861bc652bf9d51033/src/xenialdan/MagicWE2/session/UserSession.php#L114

Aericio commented 4 years ago

Appears the exclamation mark isn't supposed to be there in eng.ini (considering the color reset).

You can just remove it from eng.ini, search for tool.wand.setenabled.

Aericio commented 4 years ago

Also, your commit would break the plugin.

Nerahikada commented 4 years ago

The message should look like this and modify the plugin.

The wand tool is now <GREEN>enabled<RESET>!

For example, in Japanese, words appear between sentences. In that case, the message will look bad. https://github.com/Nerahikada/MagicWE2/blob/798381c14b12fba0bd104dacd934f95eea0a9612/resources/lang/jpn.ini#L79

Nerahikada commented 4 years ago

The plugin in the cleanup branch is already broken. 4c685171f5e52c9b338f623ffed08c6017376e38

inxomnyaa commented 4 years ago

For example, in Japanese, words appear between sentences. Darn, i only was waiting for that to happen. Sadly, this is a limitation of translations, no easy fix for that. The colors are hardcoded, i didn't want them to be inside translations to remove confusion for first time contributors.

Fix to the issue will be out soon

inxomnyaa commented 3 years ago

Took me long enough