search

inxomnyaa / MagicWE

Lag free asynchronous world editor for PMMP with plenty of options
https://poggit.pmmp.io/ci/inxomnyaa/MagicWE
GNU General Public License v3.0
101 stars 83 forks source link

[10.0.2] Paste multi-world issue #185

Closed Nerahikada closed 3 years ago

Nerahikada commented 4 years ago

Description

Multi world copy paste is not working. It seems that the same problem as #30 (#57) is occurring.

I confirmed the problem with dev-279 and dev-323.

Perhaps this problem is caused by this code. https://github.com/thebigsmileXD/MagicWE2/blob/4c685171f5e52c9b338f623ffed08c6017376e38/src/xenialdan/MagicWE2/task/AsyncPasteTask.php#L172

MagicWE2 v10.0.2 Information
Website https://github.com/thebigsmileXD/MagicWE2
Version 10.0.2
Plugin API Version 3.9, 3.10, 3.11
Authors XenialDan
Enabled Yes
Uses UI No
Phar Yes
PMMP Protocol Version v1.14.60
PMMP Version 3.12.0
PMMP API Version 3.12.0
inxomnyaa commented 4 years ago

Good find o.O

No idea why it worked for me though. New selection should contain paste level

Will debug and fix asap

inxomnyaa commented 3 years ago

Alot of code has changed and i moved on to PM4 - can you still replicate this issue?

Nerahikada commented 3 years ago

I could confirm this problem with dev431.

inxomnyaa commented 3 years ago

Fixed by https://github.com/thebigsmileXD/MagicWE2/commit/9cf30304a17593a2bc2c4c46f8d0b6e567c56f52#diff-a496283a147245056209ba90bfcf470faf331f59c7b3f5e1a298dcbd75c7182aR69