inxomnyaa / MagicWE

Lag free asynchronous world editor for PMMP with plenty of options
https://poggit.pmmp.io/ci/inxomnyaa/MagicWE
GNU General Public License v3.0
101 stars 83 forks source link

changed: minor improvements to NL translation in Grammar, spelling, a… #198

Closed Hobbesball closed 3 years ago

Hobbesball commented 4 years ago

…nd correct variable init.

Main changes:

Could you please label this PR with the label 'hacktoberfest-approved'? That way we're sure this will count towards my hacktoberfest PR's ;) Thanks <3

referencing #130

inxomnyaa commented 4 years ago

Oh, hacktoberfest-approved? looks like they've changed things, thy done

Hobbesball commented 4 years ago

Oh, hacktoberfest-approved? looks like they've changed things, thy done

hi, sorry I meant 'hacktoberfest-accepted', not approved, that's my bad! Could you change the label to hacktoberfest-accepted before merging?

Aericio commented 4 years ago

Oh, hacktoberfest-approved? looks like they've changed things, thy done

Maybe it is because of the Amazing Project PR spam that has been happening. https://github.com/search?q=Amazing+Project&type=issues


edit: Looks like that's the case, https://hacktoberfest.digitalocean.com/hacktoberfest-update

After working closely with our friends at GitHub, we are happy to introduce a new measure to help significantly reduce the amount of spammy contribution. We’re making Hacktoberfest opt-in only for projects – which maintainers can do simply by adding the ‘hacktoberfest’ topic to a repository.

Updated (10/05/2020 15:00 UTC): Individual pull requests can also be directly opted-in to Hacktoberfest with the ‘hacktoberfest-accepted’ label, on any public GitHub repository, without the need for the ‘hacktoberfest’ repository topic.

inxomnyaa commented 4 years ago

.nosession and .differentworld, something looks like it got lost