inxomnyaa / MagicWE

Lag free asynchronous world editor for PMMP with plenty of options
https://poggit.pmmp.io/ci/inxomnyaa/MagicWE
GNU General Public License v3.0
101 stars 83 forks source link

[10.1.1] Plugin not working due to PMMP API break #220

Closed Nerahikada closed 3 years ago

Nerahikada commented 3 years ago

Description

The plugin doesn't work due to API break in PMMP4.

Currently I am using https://github.com/pmmp/PocketMine-MP/commit/b2bab6c2fb87298c3d0aca544500ad63f897e930 . //copy doesn't work. (There are probably other features that are not available too.)

Console outputs when run //copy:

[03:01:20.965] [AsyncWorker#0 thread/CRITICAL]: Error: "Call to undefined method pocketmine\world\format\Chunk::getX()" (EXCEPTION) in "plugins/MagicWE2_v10.1.1/src/xenialdan/MagicWE2/selection/shape/Shape" at line 43
[03:01:20.969] [AsyncWorker#0 thread/CRITICAL]: #0 plugins/MagicWE2_v10.1.1/src/xenialdan/MagicWE2/task/AsyncCopyTask(69): xenialdan\MagicWE2\selection\shape\Shape::getChunkManager(array[1])
[03:01:20.971] [AsyncWorker#0 thread/CRITICAL]: #1 src/scheduler/AsyncTask(84): xenialdan\MagicWE2\task\AsyncCopyTask->onRun()
[03:01:20.973] [AsyncWorker#0 thread/CRITICAL]: #2 (): pocketmine\scheduler\AsyncTask->run()
[03:01:20.974] [Server thread/CRITICAL]: Could not execute asynchronous task AsyncCopyTask: Task crashed

MagicWE2 v10.1.1 Information
Website https://github.com/thebigsmileXD/MagicWE2
Version 10.1.1
Plugin API Version 4.0.0
Authors XenialDan
Enabled Yes
Uses UI Yes
Phar No
PMMP Protocol Version v1.16.100
PMMP Version 4.0.0+dev
PMMP API Version 4.0.0
inxomnyaa commented 3 years ago

The referenced commit seems to have nothing related

inxomnyaa commented 3 years ago

https://github.com/pmmp/PocketMine-MP/commit/c808095978d2699f49180230b747dc8167a2f1cf

inxomnyaa commented 3 years ago

Fixed, check palette branch

inxomnyaa commented 3 years ago

Fixed in https://github.com/thebigsmileXD/MagicWE2/commit/9cf30304a17593a2bc2c4c46f8d0b6e567c56f52