search

inxomnyaa / MagicWE

Lag free asynchronous world editor for PMMP with plenty of options
https://poggit.pmmp.io/ci/inxomnyaa/MagicWE
GNU General Public License v3.0
101 stars 83 forks source link

[10.1.6] Error thrown when trying to use blocks that are not in the r12 blockstates table #232

Closed Joshiiiii closed 3 years ago

Joshiiiii commented 3 years ago

Description

Please support costum blocks or at least ignore them. Screenshot_2289

MagicWE2 v10.1.6 Information
Website https://github.com/thebigsmileXD/MagicWE2
Version 10.1.6
Plugin API Version 4.0.0
Authors XenialDan
Enabled Yes
Uses UI Yes
Uses ScoreFactory Yes
Phar Yes
PMMP Protocol Version v1.17.10
PMMP Version 4.0.0+dev
PMMP API Version 4.0.0
inxomnyaa commented 3 years ago

Issue is caused by always checking the blockstates list, even if no states are given. Skipping this step may improve parsing performance.

inxomnyaa commented 3 years ago

Appears the fault is not the BlockStatesParser::fromString(), whoops.