search

inxomnyaa / fireworks

Adds Fireworks to Pocketmine
https://poggit.pmmp.io/ci/thebigsmileXD/fireworks/~
MIT License
20 stars 5 forks source link

Error using last PMMP relase for 1.12 #21

Open enricoangelon opened 4 years ago

enricoangelon commented 4 years ago

[Server thread/CRITICAL]: Error: "Call to undefined method pocketmine\entity\DataPropertyManager::setItem()" (EXCEPTION) in "plugins/fireworks-master/src/xenialdan/fireworks/entity/FireworksRocket" at line 42

inxomnyaa commented 4 years ago

There is an issue with pmmp since 3.9.3/3.9.2, where Mojang released 1.12 and pmmp changed SLOT_ITEM to something different. I have not yet figured out how the fireworks work in 1.12/1.13, and due to lack of debug symbols i can not retrieve the information i need via decompiling. I am hoping for anyone telling me how it works now tbh.

inxomnyaa commented 4 years ago

Can you try out https://github.com/BlockHorizons/Fireworks (Poggit: https://poggit.pmmp.io/p/Firework) and tell me if it works? I currently got no access to a client

enricoangelon commented 4 years ago

(Sorry if it took me 5 days to reply but i rarely have time). Enabling Firework v0.0.1

THEN when i launch a firework

[19:38:53] [Server thread/CRITICAL]: Error: "Call to undefined method pocketmine\entity\DataPropertyManager::getItem()" (EXCEPTION) in "plugins/Fireworks.phar/src/BlockHorizons/Fireworks/entity/FireworksRocket" at line 72

inxomnyaa commented 4 years ago

https://github.com/BlockHorizons/Fireworks/pull/5 If you'd like, you can download the phar from the pull request here: https://poggit.pmmp.io/ci/BlockHorizons/Fireworks/Fireworks/pr:3 (you might need to change build type dropdown to "pull request builds" to see the phar link) I will not further manage this repository after it being merged